Email Link Sign In Documentation + Backstack fixes #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InFragment and added documentation for email link sign in
samtstern
reviewed
Oct 28, 2018
| .ACTION_CODE_SETTINGS); | ||
|
|
||
| if (savedInstanceState == null || !savedInstanceState.getBoolean(EMAIL_SENT)) { | ||
| if (!mEmailSent && (savedInstanceState == null || !savedInstanceState.getBoolean |
There was a problem hiding this comment.
Your crazy formatter is at it again!
|
|
||
|
|
||
| private void switchFragment(Fragment fragment, String tag, boolean withTransition) { | ||
| private void switchFragment(Fragment fragment, String tag, boolean withTransition, |
There was a problem hiding this comment.
Can we make an overload without the new param that defaults it to false?
There was a problem hiding this comment.
We have one already that sets both booleans to false.
samtstern
reviewed
Oct 28, 2018
|
|
||
| @Override | ||
| public void onClickResendEmail(String email) { | ||
| if (getSupportFragmentManager().getBackStackEntryCount() > 0) { |
There was a problem hiding this comment.
Can you just add a comment here detailing the assumption you're making? As I understand it, you're assuming that if there's any back stack at all here it's due to the trouble sending flow and you want to pop from the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1501